linux-kernel - Re: [PATCH 02/27] nilfs2: disk format and userland interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080917143103.GC8750@logfs.org>
Date:	Wed, 17 Sep 2008 16:31:03 +0200
From:	Jörn Engel <joern@...fs.org>
To:	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Koji Sato <sato.koji@....ntt.co.jp>
Subject: Re: [PATCH 02/27] nilfs2: disk format and userland interface

On Mon, 15 September 2008 04:07:59 +0900, Ryusuke Konishi wrote:
>
> +struct nilfs_inode {
> +	__le64	i_blocks;
> +	__le64	i_size;
> +	__le64	i_ctime;
> +	__le64	i_mtime;
> +	__le64	i_dtime;
> +	__le32	i_uid;
> +	__le32	i_gid;
> +	__le16	i_mode;
> +	__le16	i_links_count;
> +	__le32	i_flags;
> +	__le64	i_bmap[NILFS_INODE_BMAP_SIZE];
> +#define i_device_code	i_bmap[0]
> +	__le64	i_xattr;
> +	__le32	i_generation;
> +	__le32	i_pad;
> +};

No atime.  Seems familiar. :)

Did you test the filesystem on big endian systems?  It is relatively
easy to miss bugs if conversion isn't actually necessary.

Jörn

-- 
When people work hard for you for a pat on the back, you've got
to give them that pat.
-- Robert Heinlein
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/