linux-kernel - Re: [PATCH 25/27] nilfs2: block cache for garbage collection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080917144146.GD8750@logfs.org>
Date:	Wed, 17 Sep 2008 16:41:47 +0200
From:	Jörn Engel <joern@...fs.org>
To:	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Seiji Kihara <kihara.seiji@....ntt.co.jp>,
	Yoshiji Amagai <amagai.yoshiji@....ntt.co.jp>
Subject: Re: [PATCH 25/27] nilfs2: block cache for garbage collection

On Mon, 15 September 2008 04:08:22 +0900, Ryusuke Konishi wrote:
> 
> This adds the cache of on-disk blocks to be moved in garbage
> collection.  The disk blocks are held with dummy inodes (called
> gcinodes), and this file provides lookup function of the dummy inodes,
> and their buffer read function.

Nice explanation.  Can you add it to the comment header at the top of
the file?  Unlike the GPL preample, it actually helps non-lawyers. ;)

Using dummy inodes is... unusual.  Why can you not use the actual inodes
those blocks belong to?  Or alternatively a single inode that simply
covers the complete physical device?

Jörn

-- 
All models are wrong. Some models are useful.
-- George Box
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/