linux-kernel - Re: [PATCH 6/6] x86: add KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440809170145s317e6ef8xad352e3a306abe45@mail.gmail.com>
Date:	Wed, 17 Sep 2008 01:45:05 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] x86: add KERN_APIC

On Wed, Sep 17, 2008 at 1:38 AM, Ingo Molnar <mingo@...e.hu> wrote:
>
> * Yinghai Lu <yhlu.kernel@...il.com> wrote:
>
>> and kill apic_printk
>> using loglevel=apic:8 instead
>
> yes, that aspect is very nice.
>
>> +DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 6);
>
>> -             printk(KERN_WARNING "APIC calibration not consistent "
>> +             printk(KERN_WARNING KERN_APIC "APIC calibration not consistent "
>
> here too the question arises: what should the semantics of the 'mixing'
> of such subsystem printk tags with the classic priority tags be. I think
> in this particular case we dont want the KERN_APIC tag, as that would
> prevent this failure message to be printed by default. I.e. this line
> should remain:
>
>> -             printk(KERN_WARNING "APIC calibration not consistent "
>
> to make sure this warning always shows up in the logs. Agreed?

with

DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 6);

the KERN_WARNING <5> will be showing up that warning, even without
loglevl=apic:8

or change that  to
DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 7);
?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/