| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <86802c440809170141s5c206ec9ub1ea077ed923ec20@mail.gmail.com> Date: Wed, 17 Sep 2008 01:41:03 -0700 From: "Yinghai Lu" <yhlu.kernel@...il.com> To: "Ingo Molnar" <mingo@...e.hu> Cc: "Thomas Gleixner" <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com>, "Andrew Morton" <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/6] pci: using printk(KERN_PCI v3 On Wed, Sep 17, 2008 at 1:35 AM, Ingo Molnar <mingo@...e.hu> wrote: > > * Yinghai Lu <yhlu.kernel@...il.com> wrote: > >> - printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n", >> + printk(KERN_DEBUG KERN_PCI >> + "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n", > > i think we should aim to make the common usage of this facility as easy > and short as possible. That means that i think the right line is: > > + printk(KERN_PCI > + "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n", > > as that is the shortest form. KERN_PCI should imply whatever > common-sense default. It should still make sense to specify KERN_FOO > KERN_PCI, to override that default. vprintk will add default before that like like print(KERN_INFO KERN_PCI ....) YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists