linux-kernel - Re: [patch] x86, ptrace: void dopiness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080922115058.GB14301@elte.hu>
Date:	Mon, 22 Sep 2008 13:50:58 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Markus Metzger <markus.t.metzger@...el.com>
Cc:	markus.t.metzger@...il.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, Roland McGrath <roland@...hat.com>
Subject: Re: [patch] x86, ptrace: void dopiness


* Markus Metzger <markus.t.metzger@...el.com> wrote:

> +++ gits.x86/arch/x86/kernel/ptrace.c	2008-09-19 13:53:02.%N +0200
> @@ -738,7 +738,7 @@
>  		unsigned int sig = 0;
>  
>  		/* we ignore the error in case we were not tracing child */
> -		(void)ds_release_bts(child);
> +		ds_release_bts(child);

hm, here the cast is OK because we actually ignore the return value.

> @@ -947,7 +947,7 @@
>  	clear_tsk_thread_flag(child, TIF_SYSCALL_EMU);
>  #endif
>  #ifdef CONFIG_X86_PTRACE_BTS
> -	(void)ds_release_bts(child);
> +	ds_release_bts(child);

is it right/intentional here?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/