linux-kernel - RE: [patch] x86, ptrace: void dopiness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <029E5BE7F699594398CA44E3DDF5544402781F00@swsmsx413.ger.corp.intel.com>
Date:	Mon, 22 Sep 2008 13:00:00 +0100
From:	"Metzger, Markus T" <markus.t.metzger@...el.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	<markus.t.metzger@...il.com>, <linux-kernel@...r.kernel.org>,
	<akpm@...ux-foundation.org>, "Roland McGrath" <roland@...hat.com>
Subject: RE: [patch] x86, ptrace: void dopiness

>-----Original Message-----
>From: Ingo Molnar [mailto:mingo@...e.hu] 
>Sent: Montag, 22. September 2008 13:51
>To: Metzger, Markus T
>Cc: markus.t.metzger@...il.com; linux-kernel@...r.kernel.org; 
>akpm@...ux-foundation.org; Roland McGrath
>Subject: Re: [patch] x86, ptrace: void dopiness
>
>
>* Markus Metzger <markus.t.metzger@...el.com> wrote:
>
>> +++ gits.x86/arch/x86/kernel/ptrace.c	2008-09-19 
>13:53:02.%N +0200
>> @@ -738,7 +738,7 @@
>>  		unsigned int sig = 0;
>>  
>>  		/* we ignore the error in case we were not 
>tracing child */
>> -		(void)ds_release_bts(child);
>> +		ds_release_bts(child);
>
>hm, here the cast is OK because we actually ignore the return value.
>
>> @@ -947,7 +947,7 @@
>>  	clear_tsk_thread_flag(child, TIF_SYSCALL_EMU);
>>  #endif
>>  #ifdef CONFIG_X86_PTRACE_BTS
>> -	(void)ds_release_bts(child);
>> +	ds_release_bts(child);
>
>is it right/intentional here?

The void-cast is intentional in both cases.

I thought it a question of style, i.e. that we don't want void casts
just like we want NULL instead of 0.

regards,
markus.

---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/