linux-kernel - Re: [PATCH] pcmcia: Fix broken abuse of dev->driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080922231227.2625dd09@lxorguk.ukuu.org.uk>
Date:	Mon, 22 Sep 2008 23:12:27 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Dominik Brodowski <linux@...inikbrodowski.net>
Cc:	torvalds@...l.org, linux-kernel@...r.kernel.org,
	linux-pcmcia@...ts.infradead.org
Subject: Re: [PATCH] pcmcia: Fix broken abuse of dev->driver_data

> > +	
> 
> trailing whitespace

Nod..

> >  	if (did && (did->match_flags & PCMCIA_DEV_ID_MATCH_DEVICE_NO) &&
> >  	    (p_dev->socket->device_count == 1) && (p_dev->device_no ==
> > 0)) pcmcia_add_device_later(p_dev->socket, 0);
> 
> uh?

Looks like a mailer folded it later, but the patch itself seems just fine.

> >  
> > - put_module:
> > +put_module:
> >  	if (ret)
> >  		module_put(p_drv->owner);
> > - put_dev:
> > +put_dev:
> 
> unrelated -- please do not change it this time.

Not sure you can have it both ways - if you don't want stray whitespace
then fixing the labels to conform to coding style seems to go with it ;)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/