| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080922222655.GA3792@isilmar.linta.de> Date: Tue, 23 Sep 2008 00:26:55 +0200 From: Dominik Brodowski <linux@...inikbrodowski.net> To: Alan Cox <alan@...rguk.ukuu.org.uk>, torvalds@...l.org Cc: linux-pcmcia@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] pcmcia: Fix broken abuse of dev->driver_data On Mon, Sep 22, 2008 at 11:12:27PM +0100, Alan Cox wrote: > Nod.. ... > Looks like a mailer folded it later, but the patch itself seems just fine. *gnah* already applied upstream, including the comment implying that PCMCIA driver's making use of driver_data were correct, while they were not. At least the trailing whitespace didn't get merged. > > > > > > - put_module: > > > +put_module: > > > if (ret) > > > module_put(p_drv->owner); > > > - put_dev: > > > +put_dev: > > > > unrelated -- please do not change it this time. > > Not sure you can have it both ways - if you don't want stray whitespace > then fixing the labels to conform to coding style seems to go with it ;) Well, there's a difference, and I know you know that I know that you know ;) but you should also know that I already tried to apply the patch as it is, which implies that I do not object too strongly to the removal of these two non-characters from ds.c ;) Thanks, Dominik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists