linux-kernel - Re: [PATCH 1/2] corruption check: move the corruption checks into their own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080923083643.GF23031@elte.hu>
Date:	Tue, 23 Sep 2008 10:36:43 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	linux-kernel@...r.kernel.org, Hugh Dickins <hugh@...itas.com>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
	"Randy.Dunlap" <rdunlap@...otime.net>
Subject: Re: [PATCH 1/2] corruption check: move the corruption checks into
	their own file


* Arjan van de Ven <arjan@...radead.org> wrote:

> updated patch based on feedback from Randy that I should fix 
> whitespace issues while moving code

but that's wrong. You should _never_ change code while moving it because 
it's utterly unreviewable. Please split into two patches: first move the 
code, then do the style cleanups in the target file.

also, could you please rename the new file to check.c - it's shorter and 
we might check other things there too.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/