linux-kernel - How to kick a secondary watchdog? (Re: [PATCH 1/3] watchdog: sync linux-omap changes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080923102159.GD5102@atomide.com>
Date:	Tue, 23 Sep 2008 13:22:00 +0300
From:	Tony Lindgren <tony@...mide.com>
To:	Wim Van Sebroeck <wim@...ana.be>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Felipe Balbi <me@...ipebalbi.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	"George G. Davis" <gdavis@...sta.com>, Alan Cox <alan@...hat.com>,
	Felipe Balbi <felipe.balbi@...ia.com>
Subject: How to kick a secondary watchdog? (Re: [PATCH 1/3] watchdog: sync
	linux-omap changes)

* Wim Van Sebroeck <wim@...ana.be> [080923 11:39]:
> Hi Russell,
> 
> > It's unused, but it's a minor point, something that shouldn't stand
> > in the way of it going into the watchdog tree.  It doesn't cause a
> > build error and doesn't cause malfunction.  It's just a little untidy
> > and can be addressed separately.
> 
> We will need to address it later then. I just added the patches to the
> linux-2.6-watchdog-mm tree.
> 
> > +               omap_wdt_set_timeout(wdev);
> > +               omap_wdt_enable(wdev);
> >                 spin_unlock(&wdt_lock);
> > +
> > +               omap_wdt_ping(wdev);
> > 
> > which is moving omap_wdt_ping() outside of the spin lock, which I
> > doubt actually causes any problem in real life on OMAP platforms.
> > Granted that theoretically and logically it's wrong.
> 
> And since this is indeed wrong, I changed this back.

Wim, while at it, here's a related omap_wdt question:

Some omap devices like Nokia 770, N800 and N810 have also a secondary
watchdog on the retu chip connected via cbus. This watchdog needs
to be kicked as it cannot be disabled.

We've been thinking of adding a function that omap_wdt can
call to also kick retu_wdt too as there is only one wdt interface.

Is there some better solution available?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/