linux-kernel - Re: [PATCH 4/4] x86: Add sysfs entries for UV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080923110316.GB29021@elte.hu>
Date:	Tue, 23 Sep 2008 13:03:16 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Russ Anderson <rja@....com>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	"H. Peter Anvin" <hpa@...or.com>, Jack Steiner <steiner@....com>
Subject: Re: [PATCH 4/4] x86: Add sysfs entries for UV


* Russ Anderson <rja@....com> wrote:

> +struct kobject *sgi_uv_kobj;

should be static?

> +static int __init sgi_uv_sysfs_init(void)
> +{
> +	if (!sgi_uv_kobj)
> +		sgi_uv_kobj = kobject_create_and_add("sgi_uv", firmware_kobj);
> +	if (!sgi_uv_kobj) {
> +		printk(KERN_WARNING "kobject_create_and_add sgi_uv failed \n");
> +		return -EINVAL;
> +	}
> +
> +	sysfs_create_file(sgi_uv_kobj, &partition_id_attr.attr);
> +	sysfs_create_file(sgi_uv_kobj, &coherence_id_attr.attr);

missing checks for failure?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/