linux-kernel - Re: [PATCH 2/2] corruption check: run the corruption checks from a work queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080923113303.GA14840@elte.hu>
Date:	Tue, 23 Sep 2008 13:33:03 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	"Randy.Dunlap" <rdunlap@...otime.net>,
	linux-kernel@...r.kernel.org, Hugh Dickins <hugh@...itas.com>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
Subject: Re: [PATCH 2/2] corruption check: run the corruption checks from a
	work queue


* Arjan van de Ven <arjan@...radead.org> wrote:

> On Mon, 22 Sep 2008 16:28:23 -0700 (PDT)
> "Randy.Dunlap" <rdunlap@...otime.net> wrote:
> 
> > On Mon, 22 Sep 2008, Arjan van de Ven wrote:
> > 
> > > eh a stray debug // snuck in; update attached
> > 
> > In that case, patch 1/2 contains "for(" and "while(".  :(
> > 
> 
> that's a dillema case.
> I'm just moving code around in patch 1/2; I personally consider it bad
> form to also change it at the same time.....
> 
> (and it confuses git change tracking)

correct. The right solution in this case (where code is moved around) to 
do a separate patch for the style errors Randy reported, once the code 
has been moved over.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/