linux-kernel - IDE-TAPE regressions [was: [PATCH] IDE-TAPE NULL terminate strings.]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Sep 2008 23:20:18 +0200
From:	Mark de Wever <koraq@...all.nl>
To:	petkovbb@...il.com
Cc:	Sergei Shtylyov <sshtylyov@...mvista.com>,
	Gadi Oxman <gadio@...vision.net.il>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: IDE-TAPE regressions [was: [PATCH] IDE-TAPE NULL terminate
	strings.]

On Tue, Sep 23, 2008 at 07:11:04PM +0200, Boris Petkov wrote:
> No worries and thanks. By the way, you mentioned something about other problems
> with ide-tape. FWIW, it seems you're its only user and we were about to kill it
> but decided not to yet and did the whole cleanup kinda only by compile-testing
> since almost no one (well, except you :)) has the hardware. So, feel free to
> send me any dmesg/debug/error messages you get and I'll look into them. Also,
> set IDETAPE_DEBUG_LOG to 1 before compiling for full debug info.

Thanks for not killing the driver :-) Feel free to add me to your list
of testers in case you need more testing in the future.

I already posted the problem [1] but didn't CC you since your name
wasn't listed in MAINTAINERS. I recompiled the kernel and tested again,
but the output doesn't seem to contain extra output.

In order to compile the kernel with IDETAPE_DEBUG_LOG enabled I had to
apply the following build fix.

Signed-off-by: Mark de Wever <koraq@...all.nl>

diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 3833189..7258eca 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -978,9 +978,10 @@ static ide_startstop_t idetape_do_request(ide_drive_t *drive,
 	struct request *postponed_rq = tape->postponed_rq;
 	u8 stat;
 
-	debug_log(DBG_SENSE, "sector: %ld, nr_sectors: %ld,"
+	debug_log(DBG_SENSE, "sector: %llu, nr_sectors: %ld,"
 			" current_nr_sectors: %d\n",
-			rq->sector, rq->nr_sectors, rq->current_nr_sectors);
+			(unsigned long long)rq->sector, rq->nr_sectors, 
+			rq->current_nr_sectors);
 
 	if (!blk_special_request(rq)) {
 		/* We do not support buffer cache originated requests. */


[1] http://marc.info/?l=linux-kernel&m=122203193728465&w=2

Regards,
Mark de Wever
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/