linux-kernel - Re: [PATCH] x86 gart: remove unnecessary initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080924143021.GW24392@amd.com>
Date:	Wed, 24 Sep 2008 16:30:21 +0200
From:	Joerg Roedel <joerg.roedel@....com>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
CC:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86 gart: remove unnecessary initialization

On Wed, Sep 24, 2008 at 10:41:10PM +0900, FUJITA Tomonori wrote:
> This is against tip/x86/iommu
> 
> =
> From: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> Subject: [PATCH] x86 gart: remove unnecessary initialization in struct dma_mapping_ops
> 
> There is no point to have such initialization in struct dma_mapping_ops.
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> ---
>  arch/x86/kernel/pci-gart_64.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
> index 25c94fb..b85a2f9 100644
> --- a/arch/x86/kernel/pci-gart_64.c
> +++ b/arch/x86/kernel/pci-gart_64.c
> @@ -715,12 +715,6 @@ extern int agp_amd64_init(void);
>  static struct dma_mapping_ops gart_dma_ops = {
>  	.map_single			= gart_map_single,
>  	.unmap_single			= gart_unmap_single,
> -	.sync_single_for_cpu		= NULL,
> -	.sync_single_for_device		= NULL,
> -	.sync_single_range_for_cpu	= NULL,
> -	.sync_single_range_for_device	= NULL,
> -	.sync_sg_for_cpu		= NULL,
> -	.sync_sg_for_device		= NULL,
>  	.map_sg				= gart_map_sg,
>  	.unmap_sg			= gart_unmap_sg,
>  	.alloc_coherent			= gart_alloc_coherent,

Acked-by: Joerg Roedel <joerg.roedel@....com>

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/