| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080925174948.GA14180@carmen.cs.uiuc.edu>
Date: Thu, 25 Sep 2008 12:49:48 -0500
From: Lin Tan <tammy000@...il.com>
To: linux-kernel@...r.kernel.org
Subject: [PATCH git latest] drivers/scsi: fixing wrong comment before new_buffer_tape()
(I would wish to be personally CC'ed the answers/comments posted to the list in response to my posting.)
---
Removing the wrong comment.
The lock is needed before calling new_tape_buffer(), at least in some cases.
So the comment above new_tape_buffer() is inconsistent with the code and
may mislead developers.
I simply removed the wrong comment, as I am not sure if the lock is required
in all situations. If so, we should add "Caller must hold os_scsi_tapes_lock".
Signed-off-by: Lin Tan <tammy000@...il.com>
---
--- a/drivers/scsi/osst.c 2008-09-25 11:53:09.000000000 -0500
+++ b/drivers/scsi/osst.c 2008-09-25 11:59:46.000000000 -0500
@@ -5209,7 +5209,7 @@
.
/* Memory handling routines */
-/* Try to allocate a new tape buffer skeleton. Caller must not hold os_scsi_tapes_lock */
+/* Try to allocate a new tape buffer skeleton. */
static struct osst_buffer * new_tape_buffer( int from_initialization, int need_dma, int max_sg )
{
int i;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists