linux-kernel - Re: [PATCH 1/6] bfa: Brocade BFA FC SCSI driver submission (2nd try)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080926122219.GV27204@parisc-linux.org>
Date:	Fri, 26 Sep 2008 06:22:19 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Rolf Eike Beer <eike-kernel@...tec.de>
Cc:	Jing Huang <huangj@...cade.com>,
	James.Bottomley@...senpartnership.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	rvadivel@...cade.com, srayas@...cade.com, vravindr@...cade.com
Subject: Re: [PATCH 1/6] bfa: Brocade BFA FC SCSI driver submission (2nd try)

On Fri, Sep 26, 2008 at 08:41:31AM +0200, Rolf Eike Beer wrote:
> You should use pcim_enable_device(). This would help you by simplifying your 
> error and release code as it keeps track of freeing a bunch of resources. See 
> Documentation/driver-model/devres.txt.

I hate the devres stuff.  It takes care of most things behind your back,
but is terribly complex code and makes bugs next to impossible to track
down.  Don't add more users for it unless you really, really have to.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/