linux-kernel - Re: [PATCH 1/6] bfa: Brocade BFA FC SCSI driver submission (2nd try)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080926134534.5a7d4897@lxorguk.ukuu.org.uk>
Date:	Fri, 26 Sep 2008 13:45:34 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Rolf Eike Beer <eike-kernel@...tec.de>,
	Jing Huang <huangj@...cade.com>,
	James.Bottomley@...senpartnership.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	rvadivel@...cade.com, srayas@...cade.com, vravindr@...cade.com
Subject: Re: [PATCH 1/6] bfa: Brocade BFA FC SCSI driver submission (2nd
 try)

On Fri, 26 Sep 2008 06:22:19 -0600
Matthew Wilcox <matthew@....cx> wrote:

> On Fri, Sep 26, 2008 at 08:41:31AM +0200, Rolf Eike Beer wrote:
> > You should use pcim_enable_device(). This would help you by simplifying your 
> > error and release code as it keeps track of freeing a bunch of resources. See 
> > Documentation/driver-model/devres.txt.
> 
> I hate the devres stuff.  It takes care of most things behind your back,
> but is terribly complex code and makes bugs next to impossible to track
> down.  Don't add more users for it unless you really, really have to.

Each to his own. I find the devres code very useful, but then I spend an
inordinate amount of time trying to sort out messes caused by developers
forgetting to free resources.

Using devres is a very good way to avoid having strange half tested paths
and leaks in your code, and if Matthew doesn't like the complexity of
devres (its not that complex IMHO) then he can tidy up the
implementation ;)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/