linux-kernel - Re: [PATCH git latest] drivers/net: fixing a datarace related to update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080927214424.GA12865@electric-eye.fr.zoreil.com>
Date:	Sat, 27 Sep 2008 23:44:24 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Lin Tan <tammy000@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH git latest] drivers/net: fixing a datarace related to
	update_stats()

(Please Cc: netdev@...r.kernel.org)

Lin Tan <tammy000@...il.com> :
[drivers/net/pcmcia/3c589_cs.c race]
> As indicated by the following comment, a lock must be held before calling 
> function update_stats(). This rule is followed in some cases, but not in 
> others. For example, the lock is held when the function is called in function 
> el3_get_stats(), but the lock is NOT held when called in el3_close(). It can 
> cause potential data races. 

I would not bet that the irq handler does not race with el3_close()
in the first place. Could you dig it ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/