linux-kernel - [PATCH] Markers : fix reentrancy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080930054151.GA16961@Krystal>
Date:	Tue, 30 Sep 2008 01:41:51 -0400
From:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Lai Jiangshan <laijs@...fujitsu.com>
Subject: [PATCH] Markers : fix reentrancy

Lai Jiangshan <laijs@...fujitsu.com> wrote :
> marker_synchronize_unregister must be called _also_ between unregistration
> and destruction the data that unregistration-ed probes need to make sure
> there is no caller executing a probe when it's data is destroyed.
> 

Ah, you're right. I looked again through your patch description and I
think using a :


if (entry->rcu_pending)
                rcu_barrier_sched();

After each time the markers_mutex is taken would keep the fast
batch registration/unregistration and fix the reentrancy problem.
The following patch should address the problem.

Thanks,

Mathieu


Lai Jiangshan discovered a reentrancy issue with markers. This patch implements
a version of the fix which won't slow down marker batch
registration/unregistration.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
CC: Ingo Molnar <mingo@...e.hu>
CC: Lai Jiangshan <laijs@...fujitsu.com>
CC: "Frank Ch. Eigler" <fche@...hat.com>
---
 kernel/marker.c |    6 ++++++
 1 file changed, 6 insertions(+)

Index: linux-2.6-lttng/kernel/marker.c
===================================================================
--- linux-2.6-lttng.orig/kernel/marker.c	2008-09-30 01:29:18.000000000 -0400
+++ linux-2.6-lttng/kernel/marker.c	2008-09-30 01:31:28.000000000 -0400
@@ -674,6 +674,8 @@ int marker_probe_register(const char *na
 	mutex_lock(&markers_mutex);
 	entry = get_marker(name);
 	WARN_ON(!entry);
+	if (entry->rcu_pending)
+		rcu_barrier_sched();
 	entry->oldptr = old;
 	entry->rcu_pending = 1;
 	/* write rcu_pending before calling the RCU callback */
@@ -717,6 +719,8 @@ int marker_probe_unregister(const char *
 	entry = get_marker(name);
 	if (!entry)
 		goto end;
+	if (entry->rcu_pending)
+		rcu_barrier_sched();
 	entry->oldptr = old;
 	entry->rcu_pending = 1;
 	/* write rcu_pending before calling the RCU callback */
@@ -795,6 +799,8 @@ int marker_probe_unregister_private_data
 	mutex_lock(&markers_mutex);
 	entry = get_marker_from_private_data(probe, probe_private);
 	WARN_ON(!entry);
+	if (entry->rcu_pending)
+		rcu_barrier_sched();
 	entry->oldptr = old;
 	entry->rcu_pending = 1;
 	/* write rcu_pending before calling the RCU callback */

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/