linux-kernel - Re: [PATCH] Markers : fix reentrancy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080930070923.GB30927@elte.hu>
Date:	Tue, 30 Sep 2008 09:09:23 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Lai Jiangshan <laijs@...fujitsu.com>
Subject: Re: [PATCH] Markers : fix reentrancy


* Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> wrote:

> Lai Jiangshan <laijs@...fujitsu.com> wrote :
> > marker_synchronize_unregister must be called _also_ between unregistration
> > and destruction the data that unregistration-ed probes need to make sure
> > there is no caller executing a probe when it's data is destroyed.
> > 
> 
> Ah, you're right. I looked again through your patch description and I
> think using a :
> 
> 
> if (entry->rcu_pending)
>                 rcu_barrier_sched();
> 
> After each time the markers_mutex is taken would keep the fast batch 
> registration/unregistration and fix the reentrancy problem. The 
> following patch should address the problem.

could you please send a delta patch against tip/master? Lai's patch is 
already applied and is tested. Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/