linux-kernel - Re: [PATCH 1/1] netdev: DM9000: Added typecasting to supress some warnings on Blackfin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081013.030150.96524866.davem@davemloft.net>
Date:	Mon, 13 Oct 2008 03:01:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cooloney@...nel.org
Cc:	ben@...tec.co.uk, s.hauer@...gutronix.de, jeff@...zik.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	jherrero@...istemas.es
Subject: Re: [PATCH 1/1] netdev: DM9000: Added typecasting to supress some
 warnings on Blackfin

From: Bryan Wu <cooloney@...nel.org>
Date: Mon, 13 Oct 2008 17:10:09 +0800

> From: Javier Herrero <jherrero@...istemas.es>
> 
> Signed-off-by: Javier Herrero <jherrero@...istemas.es>
> Signed-off-by: Bryan Wu <cooloney@...nel.org>

This is not only inelegant, it'll likely break things on
64-bit MIPS or any other case where the upper 32-bit matter.

I'd rather see Blackfin fix it's I/O accessor prototypes
to take a proper __iomem pointer.

This patch won't be applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/