[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081013231837.GL6646@trinity.fluff.org>
Date: Tue, 14 Oct 2008 00:18:38 +0100
From: Ben Dooks <ben-linux@...ff.org>
To: David Miller <davem@...emloft.net>
Cc: cooloney@...nel.org, ben@...tec.co.uk, s.hauer@...gutronix.de,
jeff@...zik.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, jherrero@...istemas.es
Subject: Re: [PATCH 1/1] netdev: DM9000: Added typecasting to supress some warnings on Blackfin
On Mon, Oct 13, 2008 at 03:01:50AM -0700, David Miller wrote:
> From: Bryan Wu <cooloney@...nel.org>
> Date: Mon, 13 Oct 2008 17:10:09 +0800
>
> > From: Javier Herrero <jherrero@...istemas.es>
> >
> > Signed-off-by: Javier Herrero <jherrero@...istemas.es>
> > Signed-off-by: Bryan Wu <cooloney@...nel.org>
>
> This is not only inelegant, it'll likely break things on
> 64-bit MIPS or any other case where the upper 32-bit matter.
>
> I'd rather see Blackfin fix it's I/O accessor prototypes
> to take a proper __iomem pointer.
How much would it hurt to provide blackfin wide
readsb and friends with the correct prototype and
remove the nasty blackfin hack in the dm9000.c driver
for good?
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists