linux-kernel - Re: [PATCH] Fix broken debug output reserve_region_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48F70321.8060208@zytor.com>
Date:	Thu, 16 Oct 2008 02:02:25 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	David Miller <davem@...emloft.net>
CC:	Geert.Uytterhoeven@...ycom.com, benh@...nel.crashing.org,
	linux-kernel@...r.kernel.org, mingo@...e.hu, yhlu.kernel@...il.com
Subject: Re: [PATCH] Fix broken debug output reserve_region_with_split()

David Miller wrote:
> From: Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
> Date: Thu, 16 Oct 2008 10:30:52 +0200 (CEST)
> 
>> On Mon, 13 Oct 2008, David Miller wrote:
>>> From: "H. Peter Anvin" <hpa@...or.com>
>>> Date: Mon, 13 Oct 2008 19:54:33 -0700
>>>
>>>> I pointed out that we should use the flags to determine formatting
>>>> options, e.g. I/O space is only 16 bits on x86.
>>> It's 64-bit on sparc64 :-)
>>>
>>> There's also the bit where we use a 32-bit resource_t on sparc32
>>> but encode the top 4-bits of the 36 bit physical I/O address in
>>> the resource flags member.
>> So wouldn't it be better to switch those sparc32 configs to a 64-bit
>> resource_t? I think all other platforms with 36-bit physical addresses went
>> that way.
> 
> Absolutely, this is what should happen.
> 
> I'll try to make this happen in 2.6.29, it's a moderately invasive
> change because it effects how ioremap() and friends are implemented.

Either way, it totally underscores how desirable it is to centralize 
this particular class of formatting.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/