linux-kernel - Re: [PATCH v3] Add SPI over GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Oct 2008 18:52:32 +0900
From:	"Magnus Damm" <magnus.damm@...il.com>
To:	"David Brownell" <david-b@...bell.net>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Stephen Rothwell" <sfr@...b.auug.org.au>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"Piot Skamruk" <piotr.skamruk@...il.com>,
	"Michael Buesch" <mb@...sch.de>
Subject: Re: [PATCH v3] Add SPI over GPIO driver

[removed closed openwrt-devel list]

On Fri, Oct 17, 2008 at 5:52 PM, Michael Buesch <mb@...sch.de> wrote:
> On Friday 17 October 2008 05:14:26 Magnus Damm wrote:
>> On Mon, Jul 21, 2008 at 4:46 AM, Michael Buesch <mb@...sch.de> wrote:
>> > This adds a driver that lets you drive an SPI bus over
>> > generic GPIO pins.
>> >
>> > Signed-off-by: Michael Buesch <mb@...sch.de>
>>
>> Very useful. Fits my shiny new GPIO implementation for SuperH like a glove.
>>
>> Michael, as you know, I have some SuperH board code that makes use of
>> this driver. Are there any outstanding issues with this driver that I
>> can help resolving?
>
> bool cs_activelow should probably be removed from struct spi_gpio_platform_data.
>
> I think cs always is activelow, so we can simply hardcode this in spi_gpio_chipselect()

Really? There _must_ be chips out there that want active high CS!
I'd rather keep the activelow option or maybe turn in into activehigh instead.

> If you want to do this, please feel free to do so.
> I currently don't have the time for this.
> The rest of the driver is fine with me.

Ok, thank you.

David or Andrew, any change of getting this merged as-is somehow? Thanks!

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/