linux-kernel - [PATCH v2] Fix debugfs_create_file's error checking method for arm/mach-ns9xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48F86226.60806@cn.fujitsu.com>
Date:	Fri, 17 Oct 2008 18:00:06 +0800
From:	Zhaolei <zhaolei@...fujitsu.com>
To:	Russell King <rmk+kernel@....linux.org.uk>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH v2] Fix debugfs_create_file's error checking method for arm/mach-ns9xxx

debugfs_create_file() returns NULL if an error occurs, returns -ENODEV
when debugfs is not enabled in the kernel.

Comparing to PATCH v1, because clk_debugfs_init is included in
"#if defined CONFIG_DEBUG_FS", we only need to check NULL return.
Thanks Li Zefan <lizf@...fujitsu.com>

Signed-off-by: Zhao Lei <zhaolei@...fujitsu.com>
---
 arch/arm/mach-ns9xxx/clock.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-ns9xxx/clock.c b/arch/arm/mach-ns9xxx/clock.c
index 44ed20d..f2dba83 100644
--- a/arch/arm/mach-ns9xxx/clock.c
+++ b/arch/arm/mach-ns9xxx/clock.c
@@ -208,7 +208,9 @@ static int __init clk_debugfs_init(void)
 
 	dentry = debugfs_create_file("clk", S_IFREG | S_IRUGO, NULL, NULL,
 			&clk_debugfs_operations);
-	return IS_ERR(dentry) ? PTR_ERR(dentry) : 0;
+	if (!dentry)
+		return -ENOMEM;
+	return 0;
 }
 subsys_initcall(clk_debugfs_init);
 
-- 
1.5.5.3



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/