linux-kernel - Re: [PATCH] init: Properly placing noinline keyword.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081017141354.GA9242@x200.localdomain>
Date:	Fri, 17 Oct 2008 18:13:54 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] init: Properly placing noinline keyword.

On Fri, Oct 17, 2008 at 07:05:32PM +0600, Rakib Mullick wrote:
> Here, noinline keyword should be placed between storage class and type.

Why?

> --- linux-2.6-stable.orig/init/main.c
> +++ linux-2.6-stable/init/main.c
> @@ -457,7 +457,7 @@ static void __init setup_command_line(ch
>   * gcc-3.4 accidentally inlines this function, so use noinline.
>   */
> 
> -static void noinline __init_refok rest_init(void)
> +static noinline void __init_refok rest_init(void)
>  	__releases(kernel_lock)
>  {
>  	int pid;
> @@ -792,7 +792,7 @@ static void run_init_process(char *init_
>  /* This is a non __init function. Force it to be noinline otherwise gcc
>   * makes it inline to init() and it becomes part of init.text section
>   */
> -static int noinline init_post(void)
> +static noinline int init_post(void)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/