linux-kernel - Re: rc9 + orinoco WPA patchset: BUG: scheduling while atomic loading firmware with PCMCIA adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081017204423.GB25568@comet.dominikbrodowski.net>
Date:	Fri, 17 Oct 2008 22:44:23 +0200
From:	Dominik Brodowski <linux@...inikbrodowski.net>
To:	Andrey Borzenkov <arvidjaar@...mail.ru>
Cc:	Dave <kilroyd@...glemail.com>, orinoco-devel@...ts.sourceforge.net,
	linux-wireless@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: rc9 + orinoco WPA patchset: BUG: scheduling while atomic
	loading firmware with PCMCIA adapter

Hi,

On Fri, Oct 10, 2008 at 09:26:30PM +0400, Andrey Borzenkov wrote:
> On Friday 10 October 2008, Dave wrote:
> > 
> > Andrey Borzenkov wrote:
> > > On Friday 10 October 2008, Dave wrote:
> > >> You're right. pda_size is supposed to be the maximum size of the PDA (in bytes) that we expect with the firmware. It should be set to 0x200.
> > >>
> > > 
> > > Do you want me to send a patch?
> > 
> > Could you fix it as part of the patch you submitted?
> > 
> 
> Attached. As other entries use decimal I thought it is more logical
> to use 512 as well.

> Subject: [PATCH] orinoco: reduce stack usage in firmware download path
> From: Andrey Borzenkov < arvidjaar@...l.ru>
> 
> orinoco_dl_firmware and symbol_dl_mage allocate large local
> variables (1K); at least orinoco fails with panic or hung
> kernel if 4K stacks is enabled.
> 
> Allocate large buffers dynamically at run time.
> 
> Tested-By: Andrey Borzenkov <arvidjaar@...l.ru> for Agere case
> 
> Signed-off-by: Andrey Borzenkov < arvidjaar@...l.ru>
Acked-by: Dominik Brodowski <linux@...inikbrodowski.net>

I assmue this is to be merged via wireless and net, and not via pcmcia?

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/