linux-kernel - Re: questions about rd{msr|tsc|pmc} instruction with x86-64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081020134740.GA8007@elte.hu>
Date:	Mon, 20 Oct 2008 15:47:40 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jike Song <albcamus@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, trivial@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: questions about rd{msr|tsc|pmc} instruction with x86-64


* Jike Song <albcamus@...il.com> wrote:

> H. Peter Anvin wrote:
>>  Jike Song wrote:
>> > Thanks, Peter!  So I misunderstood the gcc constraint 'A' for x86-64,
>> > but seems the comment "while x86_64 returns at rax" still wrong,
>> > should this be fixed?
>>
>>  Yes, feel free to submit a patch.
>>
>>     -hpa
> Here you go... CC trivial@...nel.org as well.
>
> From 6eed2948d41f959dc113eb3ff30927bcacf34d08 Mon Sep 17 00:00:00 2001
> From: Jike Song <albcamus@...il.com>
> Date: Fri, 17 Oct 2008 10:51:13 +0800
> Subject: [PATCH] x86: correct wrong comment
>
> The rdmsr instruction(et al) for i386 and x86-64 are semantically same.
> The only difference is how gcc interpret constraint "A" for these targets.
>
> Signed-off-by: Jike Song <albcamus@...il.com>
> ---
> include/asm-x86/msr.h |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)

applied to tip/x86/cleanups, thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/