linux-kernel - Re: [PATCH] Breaks the redundant loop in kernel/marker.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081020153850.GB27993@Krystal>
Date:	Mon, 20 Oct 2008 11:38:50 -0400
From:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Zhaolei <zhaolei@...fujitsu.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Breaks the redundant loop in kernel/marker.c

* Ingo Molnar (mingo@...e.hu) wrote:
> 
> * Zhaolei <zhaolei@...fujitsu.com> wrote:
> 
> > Ingo Molnar wrote:
> > > hm, could you describe the necessity of this patch some more? This has 
> > > the change to change behavior, which might even be a bugfix: is there 
> > > any chance that the closure-loop in the e->ptype != NULL branch does not 
> > > exit? Before your patch we'd continue the iteration - which _probably_ 
> > > does not lead to any more matches (e->name is supposed to be unique).
> > 
> > Because e->name is unique in list, we don't need to continue the iteration
> > after matched.
> > This is a cleanup.
> 
> ok - it's useful to point this out in the changelog. You can use the 
> "Impact:" header we started using recently:
> 
>     Impact: cleanup, no functionality changed
> 
> See for example this upstream commit:
> 
> | commit 07454bfff151d2465ada809bbaddf3548cc1097c
> | Author: Thomas Gleixner <tglx@...utronix.de>
> | Date:   Sat Oct 4 10:51:07 2008 +0200
> |
> |     clockevents: check broadcast tick device not the clock events device
> |
> |     Impact: jiffies increment too fast.
>  
> Mathieu, any objections against the patch?
> 
> 	Ingo

It looks all good with an extended changelog.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>

Thanks,

Mathieu

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/