linux-kernel - Re: Bug fix for pvrusb2 driver [was: Re: Kernel 2.6.26.5 -> 2.6.27.2 [USB REGRESSION] (USB -> D

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0810201231020.6072@p34.internal.lan>
Date:	Mon, 20 Oct 2008 12:33:02 -0400 (EDT)
From:	Justin Piszcz <jpiszcz@...idpixels.com>
To:	Mike Isely <isely@...ox.com>
cc:	Alan Stern <stern@...land.harvard.edu>,
	Oliver Neukum <oliver@...kum.org>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: Bug fix for pvrusb2 driver [was: Re: Kernel 2.6.26.5 -> 2.6.27.2
 [USB REGRESSION] (USB -> D_STATE)]



On Mon, 20 Oct 2008, Mike Isely wrote:

>
> There's already a patch coming up through v4l-dvb that should remove the
> need for the reset completely for the pvrusb2 driver.  The reset had
> been there as "chicken soup" previously - it didn't hurt but its
> utility wasn't really that great at the time.  Now that it is hurting,
> I just removed it.
>
>  -Mike
>

Should I wait for the patch coming up through v4l-dvb or test Alan's patch?
2.6.27.2 has quite a few issues:

1. xfs is broken w/barrier (there is a patch for this)
2. usb hangs (patch below)
3. abit-guru (comsetic issue only, doesn't find mobo) (there is a patch 
for this now as well)

So I am sticking with 2.6.26.5 right now, let me know if you need me
to test Alan's patch to see if it fixes the issue.

Justin.

>>
>> Index: usb-2.6/drivers/media/video/pvrusb2/pvrusb2-main.c
>> ===================================================================
>> --- usb-2.6.orig/drivers/media/video/pvrusb2/pvrusb2-main.c
>> +++ usb-2.6/drivers/media/video/pvrusb2/pvrusb2-main.c
>> @@ -68,6 +68,16 @@ static void pvr_setup_attach(struct pvr2
>>  #endif /* CONFIG_VIDEO_PVRUSB2_SYSFS */
>>  }
>>
>> +static int pvr_pre_reset(struct usb_interface *intf)
>> +{
>> +	return 0;
>> +}
>> +
>> +static int pvr_post_reset(struct usb_interface *intf)
>> +{
>> +	return 0;
>> +}
>> +
>>  static int pvr_probe(struct usb_interface *intf,
>>  		     const struct usb_device_id *devid)
>>  {
>> @@ -109,7 +119,9 @@ static struct usb_driver pvr_driver = {
>>  	.name =         "pvrusb2",
>>  	.id_table =     pvr2_device_table,
>>  	.probe =        pvr_probe,
>> -	.disconnect =   pvr_disconnect
>> +	.disconnect =   pvr_disconnect,
>> +	.pre_reset =	pvr_pre_reset,
>> +	.post_reset =	pvr_post_reset,
>>  };
>>
>>  /*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/