linux-kernel - Re: [PATCH] intel-iommu: use coherent_dma_mask in alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081020093824G.fujita.tomonori@lab.ntt.co.jp>
Date:	Mon, 20 Oct 2008 09:46:03 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	dwmw2@...radead.org
Cc:	fujita.tomonori@....ntt.co.jp, mgross@...ux.intel.com,
	mingo@...e.hu, grundler@...isc-linux.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] intel-iommu: use coherent_dma_mask in alloc_coherent

On Sat, 18 Oct 2008 14:46:56 +0100
David Woodhouse <dwmw2@...radead.org> wrote:

> On Wed, 2008-10-15 at 16:08 +0900, FUJITA Tomonori wrote:
> > This patch fixes intel-iommu to use dev->coherent_dma_mask in
> > alloc_coherent. Currently, intel-iommu uses dev->dma_mask in
> > alloc_coherent but alloc_coherent is supposed to use
> > coherent_dma_mask. It could break drivers that uses smaller
> > coherent_dma_mask than dma_mask (though the current code works for the
> > majority that use the same mask for coherent_dma_mask and dma_mask).
> 
> I've fixed this up to cope with the fact that dma_mask can be bigger
> than an 'unsigned long', and committed it to the iommu-2-6.git tree.

Hmm, 'unsigned long' is 64 bits on IA64 and X86_64. How can dma_mask
be bigger than an 'unsigned long'?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/