linux-kernel - Re: [PATCH 1/1] Ath5k: add AP mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40f31dec0810211108l6700d806o4804b43d9fe47bf7@mail.gmail.com>
Date:	Tue, 21 Oct 2008 21:08:41 +0300
From:	"Nick Kossifidis" <mickflemm@...il.com>
To:	"Jiri Slaby" <jirislaby@...il.com>,
	"Gregory Nietsky" <gregory@...telecom.co.za>
Cc:	linville@...driver.com, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org, ath5k-devel@...ema.h4ckr.net,
	"Luis R. Rodriguez" <mcgrof@...il.com>
Subject: Re: [PATCH 1/1] Ath5k: add AP mode

2008/10/12 Jiri Slaby <jirislaby@...il.com>:
> Add support for AP mode. This involves:
> - enablement in ath5k_beacon_config -- initialize beacon timer
> - add AP to the supported modes in ath5k_add_interface
> - handle beacon change even for AP in ath5k_config_interface
> - remove useless test for IBSS in ath5k_beacon_update
>
> Note that it doesn't enable the AP mode for the driver. It must
> be enabled by NL80211_IFTYPE_AP bit added to interface_modes.
>
> v2:
> Fixed opmode constant (IEEE80211_ to NL80211_)
>
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> Cc: Nick Kossifidis <mickflemm@...il.com>
> Cc: Luis R. Rodriguez <mcgrof@...il.com>

a) It won't work without the following as Gregory pointed out
diff --git a/drivers/net/wireless/ath5k/base.c
b/drivers/net/wireless/ath5k/base.c
index e09ed2c..69aad6e 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -488,6 +488,7 @@ ath5k_pci_probe(struct pci_dev *pdev,

       hw->wiphy->interface_modes =
               BIT(NL80211_IFTYPE_STATION) |
+               BIT(NL80211_IFTYPE_AP) |
               BIT(NL80211_IFTYPE_ADHOC) |
               BIT(NL80211_IFTYPE_MESH_POINT);

b) For some reason it only works with 5212/5213 cards, i tested it on
a 5413 and an 2425 and it didn't work (hostapd seems to hang).




-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/