linux-kernel - Re: [PATCH] x86: remove superfluous dmi_ignore_irq0_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081022100924.GC13400@alberich.amd.com>
Date:	Wed, 22 Oct 2008 12:09:24 +0200
From:	Andreas Herrmann <andreas.herrmann3@....com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: remove superfluous dmi_ignore_irq0_timer_override
	quirks

On Wed, Oct 22, 2008 at 12:02:54PM +0200, Ingo Molnar wrote:
> 
> * Andreas Herrmann <andreas.herrmann3@....com> wrote:
> 
> > The problem should be solved with commits:
> > 
> > x86: SB600: skip IRQ0 override if it is not routed to INT2 of IOAPIC
> > x86: SB450: skip IRQ0 override if it is not routed to INT2 of IOAPIC
> > 
> > IMHO it does not make sense to check within a dmi-quirk
> > whether an early-quirk was applied. Boot sequence is as follows:
> > 
> > acpi_boot_table_init()   (it applies dmi-quirks)
> > ...
> > early_quirks()           (detect bogus IRQ0 override)
> > ...
> > acpi_boot_init()         (setup IO APIC)
> > 
> > Thus with current code we will always get following warnings for
> > Laptops that have this dmi_ignore_irq0_timer_override dmi quirk:
> > 
> >   WARNING: at arch/x86/kernel/acpi/boot.c:1410
> >   dmi_ignore_irq0_timer_override+0x30/0x60()
> >   ati_ixp4x0 quirk not complete.
> > 
> > ... just because the early-quirk (ati_ixp4x0) was not yet executed.
> 
> could we move the DMI check to after the early quicks stage? It would be 
> nice to have this double check, for at least one kernel cycle.

Ok, I'll have a look at that.

Andreas


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/