linux-kernel - Re: [PATCH 03/11] ftrace: return error on failed modified text.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0810221503040.25498@gandalf.stny.rr.com>
Date:	Wed, 22 Oct 2008 15:03:24 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, fweisbec@...il.com,
	sagar.abhishek@...il.com, davem@...emloft.net, tglx@...utronix.de,
	peterz@...radead.org, torvalds@...ux-foundation.org,
	srostedt@...hat.com
Subject: Re: [PATCH 03/11] ftrace: return error on failed modified text.


On Wed, 22 Oct 2008, Andrew Morton wrote:

> On Wed, 22 Oct 2008 14:43:16 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > Return -1 on failed modified text.
> > 
> 
> changelog fails to explain the reason for the change.
> 
> > +	if (__copy_to_user_inatomic((char __user *)ip, new_code,
> > +				    MCOUNT_INSN_SIZE))
> > +		return -1;
> 
> why not -EFAULT?

Indeed, why not.  I'll update it in v2.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/