linux-kernel - Re: [PATCH 20/32] netvm: INET reserves.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48FEBAAA.5080604@suse.de>
Date:	Wed, 22 Oct 2008 11:01:22 +0530
From:	Suresh Jayaraman <sjayaraman@...e.de>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	netdev@...r.kernel.org, trond.myklebust@....uio.no,
	Daniel Lezcano <dlezcano@...ibm.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Neil Brown <neilb@...e.de>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH 20/32] netvm: INET reserves.

Hi Peter,

>>> Peter Zijlstra <a.p.zijlstra@...llo.nl> 10/02/08 7:06 PM >>>
> Add reserves for INET.

There's a typo in this patch that results in a Oops like the one below
when doing `sysctl -a'

<cut>
RIP: 0010:[<ffffffff804a0487>]  [<ffffffff804a0487>]
__mutex_lock_slowpath+0x34/0xc9

Call Trace:
 [<ffffffff804a044f>] mutex_lock+0x1a/0x1e
 [<ffffffff8044a82e>] proc_dointvec_route+0x38/0xad
 [<ffffffff80301fce>] proc_sys_call_handler+0x91/0xb8
 [<ffffffff802ba07e>] vfs_read+0xaa/0x153
 [<ffffffff802ba1e3>] sys_read+0x45/0x6e
 [<ffffffff8020c37a>] system_call_fastpath+0x16/0x1b
 [<00007fb25e415880>] 0x7fb25e415880

</cut>


Index: linux-2.6/net/ipv4/route.c
===================================================================
--- linux-2.6.orig/net/ipv4/route.c
+++ linux-2.6/net/ipv4/route.c

        /* Deprecated. Use gc_min_interval_ms */
@@ -3271,6 +3330,15 @@ int __init ip_rt_init(void)
    ipv4_dst_ops.gc_thresh = (rt_hash_mask + 1);
    ip_rt_max_size = (rt_hash_mask + 1) * 16;

+#ifdef CONFIG_PROCFS

Should be CONFIG_PROC_FS

+    mutex_init(&ipv4_route_lock);
+#endif
+
+    mem_reserve_init(&ipv4_route_reserve, "IPv4 route cache",
+            &net_rx_reserve);
+    mem_reserve_kmem_cache_set(&ipv4_route_reserve,
+            ipv4_dst_ops.kmem_cachep, ip_rt_max_size);
+
    devinet_init();
    ip_fib_init();


Thanks,

-- 
Suresh Jayaraman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/