linux-kernel - Re: [PATCH 1/7] Adding empia base driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Oct 2008 15:27:27 -0700
From:	Greg KH <greg@...ah.com>
To:	Markus Rechberger <mrechberger@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	em28xx <em28xx@...ntral.de>, acano@...tmail.fm,
	Andre Kelmanson <akelmanson@...il.com>,
	Bouwsma Barry <freebeer.bouwsma@...il.com>,
	Dan Kreiser <kreiser@...ormatik.hu-berlin.de>,
	Frank Neuber <fn@...nelport.de>,
	Jelle de Jong <jelledejong@...ercraft.nl>,
	John Stowers <john.stowers.lists@...il.com>,
	Lukas Kuna <lukas.kuna@...anet.net>,
	Stefan Vonolfen <stefan.vonolfen@...il.com>,
	Stephan Berberig <s.berberig@...or.de>,
	Thomas Giesecke <thomas.giesecke@...mbh-naumburg.de>,
	Vitaly Wool <vwool@...mvista.com>,
	Zhenyu Wang <zhen78@...il.com>
Subject: Re: [PATCH 1/7] Adding empia base driver

On Thu, Oct 23, 2008 at 12:24:31AM +0200, Markus Rechberger wrote:
> On Thu, Oct 23, 2008 at 12:09 AM, Greg KH <greg@...ah.com> wrote:
> > On Wed, Oct 22, 2008 at 11:14:36PM +0200, Markus Rechberger wrote:
> >>     em2880-dvb:
> >>     * supporting the digital part of Empia based devices, which
> >> includes ATSC, ISDB-T and DVB-T
> >
> > <snip>
> >
> > Doesn't this driver duplicate some of the existing devices we already
> > support with the current in-kernel driver?  If so, why not just add the
> > new device support to the existing driver instead of duplicating
> > everything?
> >
> > This is going to cause a big problem for distros as they will not know
> > which to enable, so they will probably just disable this one, which is
> > what I don't think you want to have happen :(
> >
> 
> the current driver doesn't support most devices which are in there,

Then why not just add new device support to the existing one?

> also the alsa audio driver can easily crash the whole system. (It's my
> code so I know what was wrong there).

Why not send patches to fix it?

> Very likely the best would be to replace the available driver with it
> but I don't care, alot people use and have been using the driver from
> mcentral.de for a long time, development has always been opensource
> there too.

Dropping existing code and replacing it entirely with a new base is not
how Linux kernel development works for the most part.

How about just sending patches in an incremental way, fixing problems in
the current driver that you know about, and adding support for all of
this goodness as well?  That's what all 2000+ other kernel developers
do when they want to make changes like this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/