linux-kernel - [PATCH RESEND]kgdb:remove redundant function invocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200810260059.06203.qhfeng.kernel@gmail.com>
Date:	Sun, 26 Oct 2008 00:59:06 +0800
From:	Qinghuang Feng <qhfeng.kernel@...il.com>
To:	jason.wessel@...driver.com
Cc:	kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: [PATCH RESEND]kgdb:remove redundant function invocation

Sorry for my resending, the previous patch can't be applied successfully.

It seems strange to call kgdboc_option_setup with parameter of config from 
configure_kgdboc(), because kgdboc_option_setup() is used to fill config
with stuff in other place. Now, kgdboc_option_setup will fill config
with config itself. But on the other hand, kgdboc_option_setup has a 
additional effect to check whether config overflows or not.

Is it ok to remove kgdboc_option_setup? 

Signed-off-by: Qinghuang Feng <qhfeng.kernel@...il.com>
---
diff --git a/drivers/serial/kgdboc.c b/drivers/serial/kgdboc.c
index eadc1ab..03f683e 100644
--- a/drivers/serial/kgdboc.c
+++ b/drivers/serial/kgdboc.c
@@ -51,8 +51,7 @@ static int configure_kgdboc(void)
 	int tty_line = 0;
 	int err;

-	err = kgdboc_option_setup(config);
-	if (err || !strlen(config) || isspace(config[0]))
+	if (!strlen(config) || isspace(config[0]))
 		goto noconfig;

 	err = -ENODEV;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/