linux-kernel - Re: [PATCH 2/2] w35und: plug memory leak in wbsoft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081028193204.GI16452@elf.ucw.cz>
Date:	Tue, 28 Oct 2008 20:32:04 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	Pekka J Enberg <penberg@...helsinki.fi>
Cc:	greg@...ah.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] w35und: plug memory leak in wbsoft_tx()

On Tue 2008-10-28 00:14:38, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@...helsinki.fi>
> 
> There's no reason to duplicate the skb in wbsoft_tx() and leak GFP_ATOMIC
> memory as the contents are copied to ->TxBuffer in MdxTx() anyway before
> MLMESendFrame() returns.

Acked-by: Pavel Machek <pavel@...e.cz>

...but I guess I should test the this after it hits the mainline...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/