linux-kernel - Re: [PATCH 2/2] w35und: plug memory leak in wbsoft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020810281408g4adda06em5cd7a620bf837b53@mail.gmail.com>
Date:	Tue, 28 Oct 2008 23:08:50 +0200
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Pavel Machek" <pavel@...e.cz>
Cc:	greg@...ah.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] w35und: plug memory leak in wbsoft_tx()

On Tue 2008-10-28 00:14:38, Pekka J Enberg wrote:
>> From: Pekka Enberg <penberg@...helsinki.fi>
>>
>> There's no reason to duplicate the skb in wbsoft_tx() and leak GFP_ATOMIC
>> memory as the contents are copied to ->TxBuffer in MdxTx() anyway before
>> MLMESendFrame() returns.

On Tue, Oct 28, 2008 at 9:32 PM, Pavel Machek <pavel@...e.cz> wrote:
> Acked-by: Pavel Machek <pavel@...e.cz>
>
> ...but I guess I should test the this after it hits the mainline...

For sure. I'm bit surprised no one noticed this before as it seems to
be leaking memory for every transmitted frame...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/