linux-kernel - Re: [PATH -mm -v2] Fix a race condtion of oops_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1225269736.24095.50.camel@yhuang-dev.sh.intel.com>
Date:	Wed, 29 Oct 2008 16:42:16 +0800
From:	Huang Ying <ying.huang@...el.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATH -mm -v2] Fix a race condtion of oops_in_progress

On Wed, 2008-10-29 at 02:34 -0600, Ingo Molnar wrote:
> * Huang Ying <ying.huang@...el.com> wrote:
> 
> > Fix a race condition accessing oops_in_progress.  Which may be 
> > changed on multiple CPU simultaneously, but it is changed via 
> > non-atomic operation ++/--.  This patch changes the definition of 
> > oops_in_process from int to atomic_t, and accessing method to atomic 
> > operations.
> > 
> > 
> > ChangeLog
> > 
> > v2:
> > 
> > - Includes fixes from Andrew Moton.
> > 
> > - Re-based on Matthew Wilcox's new atomic_t patch.
> 
> hm, there are a couple of places now that do atomic_set(,1) - they 
> should be atomic_inc(), correct?

I just translate "oops_in_progress = 1" to
"atomic_set(&oops_in_progress, 1)". I think this is the safest method to
do the translation.

Best Regards,
Huang Ying 


Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)