linux-kernel - Re: [PATH -mm -v2] Fix a race condtion of oops_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49087871.3010303@redhat.com>
Date:	Wed, 29 Oct 2008 10:51:29 -0400
From:	Chris Snook <csnook@...hat.com>
To:	Huang Ying <ying.huang@...el.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATH -mm -v2] Fix a race condtion of oops_in_progress

Huang Ying wrote:
> Fix a race condition accessing oops_in_progress.  Which may be changed on
> multiple CPU simultaneously, but it is changed via non-atomic operation
> ++/--.  This patch changes the definition of oops_in_process from int to
> atomic_t, and accessing method to atomic operations.

You also need barriers.  I believe rmb() before atomic_read() and wmb() after 
atomic_set() should suffice.

-- Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/