linux-kernel - Re: [PATH -mm -v2] Fix a race condtion of oops_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1225332179.24095.61.camel@yhuang-dev.sh.intel.com>
Date:	Thu, 30 Oct 2008 10:02:59 +0800
From:	Huang Ying <ying.huang@...el.com>
To:	Chris Snook <csnook@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATH -mm -v2] Fix a race condtion of oops_in_progress

Hi, Chris,

On Wed, 2008-10-29 at 08:51 -0600, Chris Snook wrote:
> Huang Ying wrote:
> > Fix a race condition accessing oops_in_progress.  Which may be changed on
> > multiple CPU simultaneously, but it is changed via non-atomic operation
> > ++/--.  This patch changes the definition of oops_in_process from int to
> > atomic_t, and accessing method to atomic operations.
> 
> You also need barriers.  I believe rmb() before atomic_read() and wmb() after 
> atomic_set() should suffice.

I don't think that is necessary. I haven't found there is particular
consistent requirement about oops_in_progress.

Best Regards,
Huang Ying


Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)