lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <490A8C16.6040207@oracle.com> Date: Thu, 30 Oct 2008 21:39:50 -0700 From: Randy Dunlap <randy.dunlap@...cle.com> To: Steve French <smfrench@...il.com> CC: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, Jeff Layton <jlayton@...hat.com> Subject: Re: mmotm 2008-10-30-02-23 uploaded (cifs) Steve French wrote: > On Thu, Oct 30, 2008 at 8:14 PM, Randy Dunlap <randy.dunlap@...cle.com> wrote: >> On Thu, 30 Oct 2008 02:24:25 -0700 akpm@...ux-foundation.org wrote: >> >>> The mm-of-the-moment snapshot 2008-10-30-02-23 has been uploaded to >>> >>> http://userweb.kernel.org/~akpm/mmotm/ >>> >>> It contains the following patches against 2.6.28-rc2: >> fs/cifs/connect.c: In function 'cifs_mount': >> fs/cifs/connect.c:2180: error: request for member 'sin_addr' in something not a structure or union >> >> rand-config attached. > > These line numbers don't match anywhere close to what I expect to find > in -mm based on the contents of fs/cifs in cifs-2.6.git tree. My > guess is that has a cifs patch from Jeff Layton, not in cifs-2.6.git > which may have other dependencies, and in any case IIRC has since been > removed from -mm but if not that patch may be the problem. > > The closest line I have is: > > sprintf(pSesInfo->serverName, "%u.%u.%u.%u", > NIPQUAD(sin_server.sin_addr.s_addr)); > > and since sin_server is defined as > struct sockaddr_in sin_server; > that should be fine. I can't tell you whether this is in cifs.git, but the erring lines are: tcon = find_unc(sin_server.sin_addr.s_addr, volume_info.UNC, volume_info.username); where sin_server.sin_addr should be sin_server->sin_addr. HTH. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists