linux-kernel - Re: [PATCH] el3_common_init() should be __devinit, not _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0811021008060.3483@nehalem.linux-foundation.org>
Date:	Sun, 2 Nov 2008 10:13:03 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Sam Ravnborg <sam@...nborg.org>
cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Al Viro <viro@...IV.linux.org.uk>,
	Al Viro <viro@....linux.org.uk>, linux-kernel@...r.kernel.org,
	jgarzik@...ox.com
Subject: Re: [PATCH] el3_common_init() should be __devinit, not __init



On Sat, 1 Nov 2008, Sam Ravnborg wrote:
> 
> For cpuinit/cpuexit the gain turned out to be minimal.

Quite frankly, I'm not convinced.

Yeah, yeah, most distro's end up always enabling CPU hotplug due to 
suspend/resume, but:

 - desktop PC's aren't where most memory pressures are anyway

 - on UP, CONFIG_HOTPLUG_CPU isn't on even if you do have suspend/resume

 - we should still care about embedded devices, and while some of them are 
   growing up (and having SMP and not caring about a few tens of kB of 
   memory), I don't think that's a valid argument for the other ones.

So. I'd rather we try to keep our init sections, and continue to spend 
effort on fixing them. If at all possible.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/