| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20081101211724.GA16941@uranus.ravnborg.org> Date: Sat, 1 Nov 2008 22:17:24 +0100 From: Sam Ravnborg <sam@...nborg.org> To: Alexey Dobriyan <adobriyan@...il.com> Cc: Al Viro <viro@...IV.linux.org.uk>, Al Viro <viro@....linux.org.uk>, torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org, jgarzik@...ox.com Subject: Re: [PATCH] el3_common_init() should be __devinit, not __init On Sat, Nov 01, 2008 at 10:27:57PM +0300, Alexey Dobriyan wrote: > On Sat, Nov 01, 2008 at 07:16:14PM +0000, Al Viro wrote: > > On Sat, Nov 01, 2008 at 10:12:50PM +0300, Alexey Dobriyan wrote: > > > On Sat, Nov 01, 2008 at 06:20:19PM +0000, Al Viro wrote: > > > > -static int __init el3_common_init(struct net_device *dev) > > > > +static int __devinit el3_common_init(struct net_device *dev) > > > > > > Al, here is much better patch: > > > > [essentially kill devinit/cpuinit] > > > > What the hell makes it better? > > Wasting efforts for too little gain? And what is the wasted gain - numbers please. And please come up with relevant numbers for a number of embedded configs. The normal desktop/server usage does not count here. For cpuinit/cpuexit the gain turned out to be minimal. But I have so far seen _zero_ numbers on the real gain for devinit/devexit and meminit/memexit. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists