linux-kernel - Re: [PATCH] SMC91x: delete unused local variable "lp"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081104.014511.108120668.anemo@mba.ocn.ne.jp>
Date:	Tue, 04 Nov 2008 01:45:11 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	vapier@...too.org
Cc:	nico@....org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] SMC91x: delete unused local variable "lp"

On Wed, 29 Oct 2008 09:56:06 -0400, Mike Frysinger <vapier@...too.org> wrote:
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> ---
>  drivers/net/smc91x.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
> index c70870e..6f9895d 100644
> --- a/drivers/net/smc91x.c
> +++ b/drivers/net/smc91x.c
> @@ -2060,7 +2060,6 @@ static int smc_request_attrib(struct platform_device *pdev,
>  			      struct net_device *ndev)
>  {
>  	struct resource * res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-attrib");
> -	struct smc_local *lp = netdev_priv(ndev);
>  
>  	if (!res)
>  		return 0;

The local variable 'lp' is actually used on some platforms (via
SMC_IO_SHIFT).

Please revert this change and do another way ("unused" marker or
something) to fix the warnings.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/