linux-kernel - Re: [PATCH] fix compile breakage caused by x86: add ->pre_time_init to x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081103094627.GB10400@elte.hu>
Date:	Mon, 3 Nov 2008 10:46:27 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Yinghai Lu <yhlu.kernel@...il.com>
Subject: Re: [PATCH] fix compile breakage caused by x86: add
	->pre_time_init to x86_quirks


* James Bottomley <James.Bottomley@...senPartnership.com> wrote:

> On Thu, 2008-10-30 at 23:23 +0100, Ingo Molnar wrote:
> > * James Bottomley <James.Bottomley@...senPartnership.com> wrote:
> > 
> > > >From da69eaed98248bf4b29e94d62a4e01a5c3758669 Mon Sep 17 00:00:00 2001
> > > From: James Bottomley <James.Bottomley@...senPartnership.com>
> > > Date: Wed, 29 Oct 2008 13:14:29 -0500
> > > Subject: [VOYAGER] x86: add voyager pre_time_init_hook
> > > 
> > > This was introduced by:
> > > 
> > > Author: Yinghai Lu <yhlu.kernel@...il.com>
> > > Date:   Sat Jul 19 18:02:26 2008 -0700
> > > 
> > >     x86: add ->pre_time_init to x86_quirks
> > > 
> > > In theory, voyager could also make use of the x86_quirks hooks but,
> > > unfortunately, they're not set up correctly for that to happen yet.
> > 
> > okay, so how about setting them up that way instead? That way we win 
> > twice: it becomes a tiny bit easier to add Voyager support to the 
> > generic platform code, and we also fix the build breakage.
> 
> Sure, it should be possible ... but reworking the current quirk 
> infrastructure would definitely be an enhancement, whereas this is a 
> compile fix for 2.6.28-rc

but it's an ugly compile fix that just prolongues the pain that the 
subarch code has been inflicting on us for many cycles. Please fix the 
underlying problem properly - it should not be hard and it will 
definitely be cleaner end result.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/