[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081106153215.GA23739@x61>
Date: Thu, 6 Nov 2008 16:32:15 +0100
From: Tino Keitel <tino.keitel@...ei.de>
To: ibm-acpi-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3
On Thu, Nov 06, 2008 at 12:11:21 -0200, Henrique de Moraes Holschuh wrote:
[...]
> and must set it to the higher of (saved, current) using this rule:
>
> fulll-speed > 7 > AUTO.
Maybe the level values should be changed to describe this order.
Currently, it's AUTO (0x80) > full-speed (0x40) > 7. There are already
29(!) functions just for the fan handling, so there should be enough
room for a bit of abstraction. :-) I think it could have the benefit of code
which is easier to read and maintain. Correct me if I'm wrong.
Regards,
Tino
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists