linux-kernel - Re: [PATCH] Identify which executable object the userspace address belongs to. Store thread group leader id, and use it to lookup the address in the process's map. We could have looked up the address on thread's map, but the thread might not exist by the time we are called. The process might not exist either, but if you are reading trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081106153238.GD1644@elte.hu>
Date:	Thu, 6 Nov 2008 16:32:38 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Al Viro <viro@...IV.linux.org.uk>,
	T?r?k Edwin <edwintorok@...il.com>, srostedt@...hat.com,
	a.p.zijlstra@...llo.nl, sandmann@...mi.au.dk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Identify which executable object the userspace address
	belongs to. Store thread group leader id, and use it to lookup the
	address in the process's map. We could have looked up the address
	on thread's map, but the thread might not exist by the time we are
	called. The process might not exist either, but if you are reading
	trace_pipe, that is unlikely.


* Christoph Hellwig <hch@...radead.org> wrote:

> On Thu, Nov 06, 2008 at 10:55:47AM +0100, Ingo Molnar wrote:
> > > On Mon, Nov 03, 2008 at 08:32:57AM +0100, Ingo Molnar wrote:
> > > > could you please help out with such a helper? This is really about 
> > > > visualization, not to rely on it.
> > > 
> > > Is this kindergarten? [...]
> > 
> > No, this is lkml where, if you decide to stand in the way of a patch, 
> > you are supposed to back up your NAK's with a path out of that NAK. 
> > Instead of forcing people into multiple email ping-pongs trying to 
> > figure out what exactly the objections mean.
> 
> Even if that was true, which would be avery sad world I should be 
> easy enough for you or anyone to look at what seq_path does and how 
> to have a version that doesn't use the seq_file insterface.  Takes 
> about two minutes with most of the time spent on finding where 
> seq_file is implemented.

the timeline i quoted shows that it was a 2 days process, not 2 
minutes.

It's the basic principle of communication: be forgiving in what you 
receive and conservative in what you transmit. Plus if one extra 
sentence of seemingly redundant information increases the chances to 
save an email-roundtrip down the line then please do it to increase 
communication efficiency and reduce latency.

Just to show you an example, let me give you an analogous situation in 
scheduler talk, as a reply to someone from another field who tries to 
use an existing scheduler API the wrong way:

 "
   Hey, you loser, NAK. Sync wakeups are the wrong thing to do, why 
   dont you just disable buddy wakeups for a minute in sched.c??

   [ Only two minutes to write a patch. The solution is really
     obvious to me, and we are not in the kindergarten to explain
     everything to you. And besides, the longer i make it for you to
     figure it all out, the cooler i can feel about being an
     ueber-capable scheduler hacker ;-) ]
 "

do you want such a world? i dont ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/