| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Nov 2008 22:22:56 +0100 From: Ingo Molnar <mingo@...e.hu> To: Jeremy Fitzhardinge <jeremy@...p.org> Cc: Ian Campbell <Ian.Campbell@...rix.com>, "Christopher S. Aker" <caker@...shore.net>, xen devel <xen-devel@...ts.xensource.com>, Jan Beulich <jbeulich@...ell.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [Xen-devel] 2.6.27 - SMP enabled, but only 1 CPU * Jeremy Fitzhardinge <jeremy@...p.org> wrote: > Ingo Molnar wrote: >> a "cleanup" impact line is only added if the change is not intended to >> have any side-effects whatsoever. >> >> We can drop it but it would be really nice to figure out what's going >> on. In a very quick late-night look i cannot see anything particularly >> weird about it, but based on the type of changes it does there are >> three leading candidates: lost high 32 bits, zero extend problem, or >> incorrect types. > > Yeah, I couldn't see anything either. It's a reasonable cleanup (I > never did understand that struct page * cast), but its always nicer > when cleanups don't break working code ;). Would be nice to have a look at the vmlinux delta with the patch reverted, on the .config that breaks. By all means the object code should be the same. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists